Skip to content

allow specifying docs pages as full width if their content requires it #14375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

armcknight
Copy link
Member

This is one option for fixing the table formatting issue in #14227

Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 10:02pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 10:02pm

Copy link

codecov bot commented Jul 15, 2025

Bundle Report

Changes will increase total bundle size by 190.97kB (0.87%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.99MB 190.97kB (1.62%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/oivCNTUMprQfr0oS6w94x/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/oivCNTUMprQfr0oS6w94x/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/x5KjgZ5Z3Sj1NyUzNLKcS/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/x5KjgZ5Z3Sj1NyUzNLKcS/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js 37.57kB 1.68MB 2.29%
../instrumentation.js 37.57kB 1.01MB 3.86%
9523.js 37.57kB 986.88kB 3.96%
../app/[[...path]]/page.js.nft.json 26.08kB 717.48kB 3.77%
../app/platform-redirect/page.js.nft.json 26.08kB 717.4kB 3.77%
../app/sitemap.xml/route.js.nft.json 26.08kB 715.37kB 3.78%
../app/[[...path]]/page.js 22 bytes 591.64kB 0.0%

Files in ../app/[[...path]]/page.js:

  • ./app/[[...path]]/page.tsx → Total Size: 11.03kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 22 bytes 3.14MB 0.0%

@coolguyzone
Copy link
Contributor

@armcknight Thanks for putting this together! Looks like it's breaking because of typescript linting issue:

Screenshot 2025-07-17 at 2 40 15 PM

@chargome
Copy link
Member

Do you want to handle the according CSS also in this pr?

@armcknight
Copy link
Member Author

@chargome I may need help, I'm not sure what would be required.

@armcknight armcknight merged commit 27118bb into armcknight/fix/user-feedback-swiftui Aug 6, 2025
8 checks passed
@armcknight armcknight deleted the armcknight/full-width-option branch August 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants